Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14672 Update approval type to be required field in restoration schema #131

Merged
merged 1 commit into from
Mar 31, 2023
Merged

14672 Update approval type to be required field in restoration schema #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/registry_schemas/schemas/restoration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"type": "object",
"required": [
"type",
"approvalType",
"offices",
"parties",
"contactPoint"
Expand Down Expand Up @@ -49,6 +50,7 @@
"approvalType": {
"type": "string",
"title": "The Type of Approval, such as Approved by Court or Registrar.",
"description": "In the case of a limited restoration extension or limited restoration to full filing, the approval type needs to the same value as the original limited restoration filing.",
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
"enum": [
"courtOrder",
"registrar"
Expand Down
2 changes: 1 addition & 1 deletion src/registry_schemas/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
"""


__version__ = '2.18.4' # pylint: disable=invalid-name
__version__ = '2.18.5' # pylint: disable=invalid-name
1 change: 0 additions & 1 deletion tests/unit/test_restoration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ def test_limited_restoration_extension():
restoration_json = copy.deepcopy(RESTORATION)
restoration_json['type'] = 'limitedRestorationExtension'
restoration_json['expiry'] = '2023-01-18'
del restoration_json['approvalType']
del restoration_json['nameRequest']
del restoration_json['nameTranslations']

Expand Down