UI: Tax Number and Tax Residency #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpeinanw
requested review from
hfekete and
kialj876
and removed request for
hfekete
hfekete
requested changes
Nov 9, 2023
btr-web/btr-common-components/cypress/e2e/pages/examples/form/full-name.cy.ts
Show resolved
Hide resolved
btr-web/btr-main-app/components/individual-person/tax-info/TaxNumber.vue
Outdated
Show resolved
Hide resolved
btr-web/btr-main-app/components/individual-person/tax-info/TaxNumber.vue
Outdated
Show resolved
Hide resolved
btr-web/btr-main-app/components/individual-person/tax-info/TaxNumber.vue
Outdated
Show resolved
Hide resolved
btr-web/btr-main-app/components/individual-person/tax-info/TaxNumber.vue
Outdated
Show resolved
Hide resolved
btr-web/btr-main-app/components/individual-person/tax-info/TaxNumber.vue
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage ? 91.81%
=======================================
Files ? 11
Lines ? 599
Branches ? 22
=======================================
Hits ? 550
Misses ? 29
Partials ? 20
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-48-ux5a913e.web.app |
patrickpeinanw
commented
Nov 10, 2023
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-48-ux5a913e.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-48-ux5a913e.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-48-ux5a913e.web.app |
kialj876
reviewed
Nov 10, 2023
btr-web/btr-main-app/components/individual-person/tax-info/TaxNumber.vue
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-48-ux5a913e.web.app |
kialj876
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#17981
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).