Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1670 install oc for pr undeploy action. #1546

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

WalterMoar
Copy link
Collaborator

@WalterMoar WalterMoar commented Dec 16, 2024

Description

GitHub has changed the ubuntu-latest image to no longer include the oc command. Add it as a separate step, similar to how the PR Deploy Action works.

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

Note: We unfortunately have to merge Actions before we can try them out. Fingers crossed.

GitHub has removed "oc" from the "ubuntu-latest" image. Do an explicit install of it.
Copy link
Collaborator

@usingtechnology usingtechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow! Simple... nice they built in that action. (And you knew about it).

@usingtechnology usingtechnology merged commit e8324f9 into bcgov:main Dec 16, 2024
5 checks passed
- name: Install OpenShift CLI tools
uses: redhat-actions/openshift-tools-installer@v1
with:
oc: "4.14"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: it's nice having control over the version of the tools, so we can match it to the OCP version. The downside is that we need to maintain it, so this (and the version in the Deploy Action) will need to be bumped to 4.16 after the double-update of OCP that is coming early next year. Maybe we can put this into an environment variable at some point.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... yeah, one more thing to stay on top of and one more point of failure. Old repos look out!

@WalterMoar WalterMoar deleted the fix/1670-pr-undeploy-add-oc branch December 16, 2024 17:47
@WalterMoar
Copy link
Collaborator Author

Oh, wow! Simple... nice they built in that action. (And you knew about it).

The full story is that one day the Deploy Action stopped working. GitHub had done a surprise change of ubuntu-latest to 24.04, and they pared it down to no longer include a bunch of stuff - including oc. GitHub broke enough people that they reverted ubuntu-latest to 22.04 and then publicized that the change to 24.04 was coming - I guess we passed that date where 24.04 without oc is now the runner for the Actions.

We had previously fixed the Deploy action to explicitly install oc but I guess we never did it for Undeploy because it was still working after GitHub reverted to 22.04!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants