Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1670 install oc for pr undeploy action. #1546

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: FORMS-1670 install oc for pr undeploy action. #1546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/pr_undeploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install OpenShift CLI tools
uses: redhat-actions/openshift-tools-installer@v1
with:
oc: "4.14"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: it's nice having control over the version of the tools, so we can match it to the OCP version. The downside is that we need to maintain it, so this (and the version in the Deploy Action) will need to be bumped to 4.16 after the double-update of OCP that is coming early next year. Maybe we can put this into an environment variable at some point.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... yeah, one more thing to stay on top of and one more point of failure. Old repos look out!

- name: Login to OpenShift Cluster
uses: redhat-actions/oc-login@v1
with:
Expand Down
Loading