UI - MHR Manufacturer Registration modal

[mstanton1]

• Add new 'Registration Successful' Modal for MHR table after manufacturer registration is complete (see design comps)
• Note, unlike other modals this has a rule to not show again in the current session or future sessions if the user selects 'Do not show this message again'
• use user preferences to hide modal for future sessions
• link account ID inside user preferences (see example for user access messaging)

See updated design comps: https://app.zenhub.com/workspaces/design-team-space-6144b1bb15dbac0013e68828/issues/gh/bcgov/entity/17554

[mstanton1]

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett @RuoxuanPengBC

[dimak1]

@tlebedovich this ticket is blocked by a Design ticket. Is it done, and I can pick it up? Or is the design still in progress?

[tlebedovich]

@dimak1 - design ticket is not a blocker, just a way to attach it to the dev ticket, its ready to go

[dimak1]

Thanks @tlebedovich maybe instead in the future, we can just add design ticket to the Description (instead of Blocked By section).

[tlebedovich]

we usually add the design ticket as a blocker to the epic/story instead of a link in individual tickets (which can become outdated), unless they are smaller independent tickets. We need to add as blocker so we have a permanent link between the dev and design tickets. I can close the design ticket though so it doesn't read as still being an active blocker.

[dimak1]

Yes, I think it would be better if the Blocker ticket would be closed. Thank you!

[dimak1]

@tlebedovich link for UXA: https://bcregistry-assets-dev--pr-1605-cfyfkh09.web.app/

[tlebedovich]

Hi @dimak1 - looks good for Manufacturer registration but this modal should not be appearing for Staff registrations. It's just for Manufacturer registrations. When I was logged in as staff and did a staff registration I saw the modal:

[dimak1]

Thanks @tlebedovich, missed this small print req. Will update and let you know.

[dimak1]

@tlebedovich here is a fix for Staff: https://bcregistry-assets-dev--pr-1605-cfyfkh09.web.app/

[tlebedovich]

@dimak1 - modal no longer showing for Staff, thanks. To note now though that it doesn't appear to be autoscrolling properly to the table and I can't see the green highlight when completing a staff registration. Can you just check that the global 5 sec for green highlight, snackbar and autoscroll is in there? Thanks.

for me it just got stuck at the top of the MHR dashboard and never autoscrolled to the table with highlighted row:

[dimak1]

@tlebedovich I just updated the timeout to be 5 seconds, but I will check again and let you know.

[dimak1]

@tlebedovich I logged in to the preview link as a Manufacturer and Registered a Manufactured home. I saw the snackbar message and auto-scroll. I did not see the Successful Registration dialog because it was already dismissed via checkbox in prev session.
Private Zenhub Image
Private Zenhub Image

[tlebedovich]

HI @dimak1 - my comments above were specifically when doing a staff registration, logged in as staff. Manufacturer registration works as it should.

[dimak1]

@tlebedovich my bad, I just tried with Staff role and all looks good on my end.

Private Zenhub Image

Private Zenhub Image

[tlebedovich]

@dimak1 interesting. ok then, lets move this ticket along!

[dimak1]

Sounds good, will move along. We can try it again after deployment to DEV.

[chdivyareddy]

Hey @dimak1 , after filing MH registration for QS, the user is not auto-scrolled to the registration in the background and after clicking on the 'OK' button in the MHR modal, new MH registration is not displayed in the table until the dashboard is reloaded. Please take a look, thanks!!

View after filing the MH registration - User is taken to the dashboard, but not autoscrolled to the MHR table:
Private Zenhub Image

MHR table view after filing the registration - new registration is not added to the table
Private Zenhub Image

MHR table view after reloading the dashboard:
Private Zenhub Image

[dimak1]

Hi @chdivyareddy, from my understanding, it is not supposed to auto-scroll after clicking OK. The OK button only closes the modal. It would scroll in the background, and the message would stay on for 5 seconds only.

I checked the DEV and it does show the modal, which is that this ticket is about. Only for 'MHR Only' account I did not see the autoscroll because the table is not updated until the page refresh. I think this is a separate issue for a new bug, Unless we want to fix it in this ticket?

[chdivyareddy]

@dimak1 , can you please let me know the other account in DEV which has Manufacturer role, because I use this account for testing, thanks!!

[dimak1]

@chdivyareddy sent you a private msg.

[dimak1]

@chdivyareddy as discussed, I will work on the auto-scroll issue as part of this ticket.

[chdivyareddy]

Hey @dimak1 , just noticed that this modal is being displayed for PPR registrations with accounts which has PPR only table (BCREG0058 in TEST). Can you please take a look, thanks!!

Private Zenhub Image

[dimak1]

@chdivyareddy will take a look.

I also noticed that when adding MHR to the table via 'Retrieve an existing registration...' field, the modal is also showing, because we are adding a row to the table (either via new registration or existing). Both ways are addition (with a snackbar message), so that's why. cc: @tlebedovich

[tlebedovich]

@dimak1 we definitely don't want the modal appearing anytime other than when a Manufacturer creates a new registration.

[dimak1]

@chdivyareddy @tlebedovich I fixed the dialog so it won't show up when adding existing registration to the table.

I could not reproduce the issue where it won't scroll to the newly added registration. I would need to try after the preview link is generated shortly.

[dimak1]

UXA link: https://bcregistry-assets-dev--pr-1624-ua5slngo.web.app/

[chdivyareddy]

@dimak1 , I just verified in DEV using BCREG0051 account and still see the same issue, that the MHR modal is displayed for PPR registrations when user files new registrations and/or adds manually to the PPR and MHR tables. Please take a look, thanks!! Let me know if you would like to reproduce them!!

• When the user files a PPR registration and/or adds a PPR registration manually to the table via 'Retrieve an existing registration to add to your table:'
  Private Zenhub Image

• When the MHR registration is manually added to the table via 'Retrieve an existing registration to add to your table:'

Private Zenhub Image

[dimak1]

Hi @chdivyareddy I fixed this and verified with preview link. It is now pushed to DEV.

[chdivyareddy]

@dimak1 , will take a look now...thank you!!

[chdivyareddy]

Hey @dimak1 , Verified in DEV with the staff account and client accounts with Assets dashboard, PPR only and MHR only account and the modal is displayed for only the QS manufacturer registrations as expected. The only issue is the auto-scrolling is not working as expected for the MHR only account (BCREG0051).

Private Zenhub Image

[chdivyareddy]

Created #18666 for the auto-scroll issue, moving this ticket along.