Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UXA for Success Reg Dialog #1624

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Nov 18, 2023

Issue #:

Description of changes:

  • UXA for MHR Success Registration Dialog to prevent it from showing up when adding existing registration to the table

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added MHR Registration UXA Updates for UXA feedback labels Nov 18, 2023
@dimak1 dimak1 self-assigned this Nov 18, 2023
@dimak1
Copy link
Collaborator Author

dimak1 commented Nov 18, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1624-ua5slngo.web.app

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #1624 (60f317e) into main (9255e77) will increase coverage by 4.90%.
Report is 325 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
+ Coverage   72.35%   77.25%   +4.90%     
==========================================
  Files         307      379      +72     
  Lines       12767     7027    -5740     
  Branches     2630     1124    -1506     
==========================================
- Hits         9237     5429    -3808     
+ Misses       3518     1566    -1952     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.25% <ø> (+4.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 34 more

... and 281 files with indirect coverage changes

@dimak1 dimak1 merged commit 4919e4d into bcgov:main Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR Registration UXA Updates for UXA feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants