Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration Success Dialog for MHR only #1625

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Nov 20, 2023

Issue #: /bcgov/entity#17783

Description of changes:

  • Fix to show Registration Success Dialog for MHR only

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1
Copy link
Collaborator Author

dimak1 commented Nov 20, 2023

/gcbrun

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #1625 (4c49c7a) into main (9255e77) will increase coverage by 4.86%.
Report is 327 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
+ Coverage   72.35%   77.21%   +4.86%     
==========================================
  Files         307      381      +74     
  Lines       12767     7052    -5715     
  Branches     2630     1129    -1501     
==========================================
- Hits         9237     5445    -3792     
+ Misses       3518     1575    -1943     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.21% <ø> (+4.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 34 more

... and 283 files with indirect coverage changes

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1625-htirq90w.web.app

@dimak1 dimak1 merged commit 92c6c62 into bcgov:main Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants