Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS-2673: Changes to Readme.md and contribute.md #116

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

SateeshFW
Copy link

@SateeshFW SateeshFW commented Jul 29, 2024

Following changes are done.

Renamed the current readme.md file to contribute.md

  • Cleaned up the new file contribute.md to remove broken links and formatted the file.

Created a new readme.md and following changes are done in it:

  • Added a title

  • Added description

  • Added installation section

Added usage section

  • Added contact / support info section with Rocket chat and Github issue tracker details.
  • Added 'link to contribute doc' section

SateeshFW added 4 commits July 29, 2024 10:56
APS-2673, Removed the old URLs and added the correct one.  Formatted the headers and content.
APS-2673, Removed the build badge
@SateeshFW SateeshFW requested a review from rustyjux July 29, 2024 19:50
@rustyjux rustyjux changed the base branch from main to feature/ns-to-gw July 29, 2024 19:52
Copy link

@rustyjux rustyjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the provided suggestions.

Some of these are maybe a bit of a style thing but I think readme's are very much the place to be concise and not overly wordy.

E.g. see https://github.com/netlify/cli, https://github.com/Shopify/cli - this is a place where short and sweet (but adequately comprehensive content-wise) is best.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
APS-2673, Incorporated the PR comments
Copy link

@rustyjux rustyjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SateeshFW SateeshFW merged commit b62440f into feature/ns-to-gw Jul 30, 2024
1 check passed
@SateeshFW SateeshFW deleted the APS-2673 branch July 30, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants