17171 compare sorted name (#2171)

bcgov · Aug 8, 2023 · 6e4130f · 6e4130f
1 parent 9961523
commit 6e4130f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/legal-api/src/legal_api/reports/report.py b/legal-api/src/legal_api/reports/report.py
@@ -803,7 +803,9 @@ def _format_name_translations_data(self, filing, prev_completed_filing: Filing):
         versioned_name_translations = VersionedBusinessDetailsService.\
             get_name_translations_revision(prev_completed_filing.transaction_id, self._business.id)
         filing['previousNameTranslations'] = versioned_name_translations
-        filing['nameTranslationsChange'] = sorted(filing['listOfTranslations']) != sorted(versioned_name_translations)
+        filing['nameTranslationsChange'] = \
+            sorted([translation['name'] for translation in filing['listOfTranslations']]) != \
+            sorted([translation['name'] for translation in versioned_name_translations])
 
     def _format_office_data(self, filing, prev_completed_filing: Filing):
         filing['offices'] = {}