Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17171 compare sorted name #2171

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

vysakh-menon-aot
Copy link
Collaborator

Issue #: /bcgov/entity#17171

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@vysakh-menon-aot vysakh-menon-aot self-assigned this Aug 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
18.2% 18.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2171 (bd52975) into main (53b46e4) will decrease coverage by 0.35%.
Report is 23 commits behind head on main.
The diff coverage is 45.80%.

@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
- Coverage   77.16%   76.82%   -0.35%     
==========================================
  Files         222      224       +2     
  Lines       12759    12807      +48     
  Branches     2126     2142      +16     
==========================================
- Hits         9846     9839       -7     
- Misses       2272     2324      +52     
- Partials      641      644       +3     
Flag Coverage Δ
legalapi 76.91% <45.80%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rvices/entity-emailer/src/entity_emailer/config.py 100.00% <ø> (ø)
...ailer/email_processors/ar_reminder_notification.py 100.00% <ø> (ø)
...mailer/email_processors/correction_notification.py 72.16% <ø> (-1.37%) ⬇️
...ailer/email_processors/dissolution_notification.py 51.48% <ø> (+2.88%) ⬆️
...iler/email_processors/special_resolution_helper.py 85.36% <ø> (+0.36%) ⬆️
...mail_processors/special_resolution_notification.py 97.56% <ø> (-0.06%) ⬇️
...iler/src/entity_emailer/message_tracker/tracker.py 83.33% <ø> (-0.17%) ⬇️
...vices/entity-emailer/src/entity_emailer/version.py 100.00% <ø> (ø)
...rvices/entity-emailer/src/entity_emailer/worker.py 72.00% <ø> (-0.23%) ⬇️
...r/src/entity_filer/filing_processors/alteration.py 92.00% <ø> (-0.31%) ⬇️
... and 15 more

@vysakh-menon-aot vysakh-menon-aot merged commit 6e4130f into bcgov:main Aug 8, 2023
7 of 9 checks passed
@vysakh-menon-aot vysakh-menon-aot deleted the feature/17171 branch August 8, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants