Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colin-api: good standing bug fix #2208

Merged
merged 1 commit into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion colin-api/src/colin_api/models/business.py
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ def is_in_good_standing(business: dict, cursor) -> Optional[bool]:
# good standing is irrelevant to non active and nwpta businesses
return None
if business['corp_class'] in ['BC'] or business['corp_typ_cd'] in ['LLC', 'LIC', 'A', 'B']:
if business.get('state_typ_cd') in ['D1A', 'D1F', 'D1T', 'D2A', 'D2F', 'D2T', 'LIQ', 'LRL', 'LRS']:
if business.get('corp_state') in ['D1A', 'D1F', 'D1T', 'D2A', 'D2F', 'D2T', 'LIQ', 'LRL', 'LRS']:
# Dissolution state or Liquidation or Limited Restoration or is NOT in good standing
# - updates into Dissolution states occur irregularly via batch job
# - updates out of these states occur immediately when filing is processed
Expand Down
2 changes: 1 addition & 1 deletion colin-api/src/colin_api/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
Development release segment: .devN
"""

__version__ = '2.86.1' # pylint: disable=invalid-name
__version__ = '2.86.2' # pylint: disable=invalid-name
Loading