Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: digital credential queue service tests #2330

Merged
merged 81 commits into from
Nov 27, 2023

fix: code smells

f3c1a00
Select commit
Loading
Failed to load commit list.
Merged

feat: digital credential queue service tests #2330

fix: code smells
f3c1a00
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Nov 27, 2023 in 44s

3 secrets uncovered!

3 secrets were uncovered from the scan of 81 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #2330: feature-digital-credentials 👉 main
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret fd96a6e legal-api/tests/unit/models/test_dc_definition.py View secret
- Generic High Entropy Secret fc6c34a legal-api/tests/unit/models/test_dc_definition.py View secret
7220870 Generic High Entropy Secret 6beb1b1 legal-api/tests/unit/models/test_dc_definition.py View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!