-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: digital credential queue service tests #2330
feat: digital credential queue service tests #2330
Conversation
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: devcontainer configuraton for vscode Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: issue credentials through Traction tenant Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: app initialization workflow Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use out-of-band invitation for connecting Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use v2.0 for issuing credential Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: web socket implmentation with flask-socketio Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: db migration script to enable revocation Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: revocation endpoint Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: replace endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update requirements Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: traction token exchanger Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: ws cors setting is a config option Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: clean up init in digital credential service Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
…nto feature-digital-credentials
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: devcontainer configuraton for vscode Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: issue credentials through Traction tenant Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: app initialization workflow Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use out-of-band invitation for connecting Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use v2.0 for issuing credential Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: web socket implmentation with flask-socketio Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: db migration script to enable revocation Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: revocation endpoint Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: replace endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update requirements Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: traction token exchanger Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: ws cors setting is a config option Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: clean up init in digital credential service Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: endpoints to reset credential offers Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: credential id lookup table Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: add business roles Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix tests and linting Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix tests Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
…nto feature-digital-credentials
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | fd96a6e | legal-api/tests/unit/models/test_dc_definition.py | View secret |
- | Generic High Entropy Secret | fc6c34a | legal-api/tests/unit/models/test_dc_definition.py | View secret |
7220870 | Generic High Entropy Secret | 6beb1b1 | legal-api/tests/unit/models/test_dc_definition.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 77.37% 76.37% -1.01%
==========================================
Files 202 176 -26
Lines 11602 10445 -1157
Branches 1961 1761 -200
==========================================
- Hits 8977 7977 -1000
+ Misses 2043 1988 -55
+ Partials 582 480 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Codecov is failing to upload an artifact |
...ces/entity-digital-credentials/tests/unit/digital_credentials_processors/test_dissolution.py
Show resolved
Hide resolved
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Looks good. Thanks for the tests! Can we address the remaining 2 code smells? |
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Issue #: /bcgov/entity#18521
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).