Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: digital credentials queue helper tests #2334

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

amanji
Copy link
Contributor

@amanji amanji commented Nov 27, 2023

Issue #: /bcgov/entity#18521

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@argush3 argush3 self-requested a review November 27, 2023 23:40
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2334 (a55d3c8) into main (79511cd) will increase coverage by 9.47%.
Report is 38 commits behind head on main.
The diff coverage is 86.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
+ Coverage   77.37%   86.85%   +9.47%     
==========================================
  Files         202       11     -191     
  Lines       11602      251   -11351     
  Branches     1961       41    -1920     
==========================================
- Hits         8977      218    -8759     
+ Misses       2043       23    -2020     
+ Partials      582       10     -572     
Flag Coverage Δ
entity-digital-credentials 86.85% <86.85%> (?)
entityfiler ?
legalapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...entials/src/entity_digital_credentials/__init__.py 100.00% <100.00%> (ø)
...entials/digital_credentials_processors/__init__.py 100.00% <100.00%> (ø)
...als/digital_credentials_processors/admin_revoke.py 100.00% <100.00%> (ø)
.../digital_credentials_processors/business_number.py 100.00% <100.00%> (ø)
...l_credentials_processors/change_of_registration.py 100.00% <100.00%> (ø)
...ials/digital_credentials_processors/dissolution.py 100.00% <100.00%> (ø)
...ials/digital_credentials_processors/put_back_on.py 100.00% <100.00%> (ø)
...dentials/src/entity_digital_credentials/version.py 0.00% <0.00%> (ø)
...dentials/src/entity_digital_credentials/helpers.py 94.54% <94.54%> (ø)
...edentials/src/entity_digital_credentials/config.py 92.85% <92.85%> (ø)
... and 1 more

... and 202 files with indirect coverage changes

Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@argush3 argush3 merged commit 0d61a2a into bcgov:main Nov 28, 2023
8 checks passed
@amanji amanji changed the title Feature digital credentials feat: digital credentials queue tests Nov 28, 2023
@amanji amanji changed the title feat: digital credentials queue tests feat: digital credentials queue helper tests Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants