23348 - Add allowable actions for notice of withdrawal #3014
Conversation
AimeeGao
requested review from
kzdev420,
chenhongjing,
JazzarKarim,
leodube-aot and
eason-pan-bc
| 'business': [BusinessBlocker.BUSINESS_FROZEN, | ||
| BusinessBlocker.NO_FUTURE_EFFECTIVE_FILING] |
There was a problem hiding this comment.
There's a scenario that I think you should think of...A business has a FED filing and not in frozen status but it also has a draft NoW filing, in this case, it should be not allowed to start another NoW filing again.
There was a problem hiding this comment.
You should make this filing support for both temporary business(new) and existing business.
References:
allowable actions for amalgamataion application
business requirement check
flow to save filing
| identifier = (f'BC{random.SystemRandom().getrandbits(0x58)}')[:9] | ||
| business = factory_business(identifier=identifier, |
There was a problem hiding this comment.
It will be better if you can add some tests for temporary business scenarios. 💭
|
There was a problem hiding this comment.
As per our conversations with Argus, there should be extra design and investigation on the scenarios of temporary businesses. As the priorities are shifting, we may hold off further NoW work. So now we only handle allowable actions for existing businesses, and it will be good if you add some comments on the spreadsheet, and leave notes for QA. Overall, good work!
Thank you, Hongjing, for your detailed explanation and reminder. I’ve added comments for the Notice of Withdrawal in the spreadsheet, and I will also leave relevant notes for QA. |
* 23348 - Add allowable actions for notice of withdrawal (#3014) * Add notice of withdrawal for existing business * 23349 - validation notice of withdrawal (#3020) * implement validation logic for NoW * update schema version number in requirements * exclude the new business scenario * 23539 add batch_processing to colin_event_ids table (#3021) * 23539 add batch_processing to colin_event_ids table * add relationship, tests * fix downgrade issue * remove re-define batch_processing_step enum * 23608 - Update furnishing entries transferred to bc mail+ (#3025) * Fix bug * 23697 - fix stage1 to stage2 dissolution transition bug (#3028) * add SFTP off feature flag, modify stage 2 furnishing entry check, update tests * adjust mail status check when FF is on * add feature flag "disable-dissolution-sftp-bclaws" * refactor stage 1 furnishing entries check * update tests * 23522-23562 continuation in workflow change (#3026) * 23572 update dissolution letters (#3023) * 23572 update dissolution letters * add the dots * 23845 - Bumped version numbers up for release 23.2a (#3030) * bump version * update entity-bn version * udpate version * 23563 - update review endpoint (#3029) * 23563 - update review endpoint * 23563 - update api spec * 23563 - update api spec filing description * Undo colin_event_id model changes (#3032) --------- Co-authored-by: Aimee <Aimee.Gao@gov.bc.ca> Co-authored-by: EasonPan <Eason.Pan@gov.bc.ca> Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com> Co-authored-by: Vysakh Menon <vysakh.menon@gov.bc.ca> Co-authored-by: ketaki-deodhar <116035339+ketaki-deodhar@users.noreply.github.com> Co-authored-by: leodube-aot <122323255+leodube-aot@users.noreply.github.com>
Issue #: /bcgov/entity#23348
Description of changes:
Note
This implementation only covers the Notice of Withdrawal logic for existing businesses. The temporary business scenario is currently excluded.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).