Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23349 - validation notice of withdrawal #3020

Merged

Conversation

eason-pan-bc
Copy link
Collaborator

@eason-pan-bc eason-pan-bc commented Oct 4, 2024

Issue #: /bcgov/entity#23349

Description of changes:

  • Added validation for Notice of Withdrawal filings, checking:
    • the to be withdrawn filing exist
    • it has a FED
    • its status is PAID
  • Added unit tests testing withdraw a filing from an existing business, as discussed, excluding the new business scenario.
  • Updated the Registry Schema version number

Testing Results:

  • All unit tests passed
    Pasted image 20241004114510
  • Linting Cleared
    Pasted image 20241004134344
  • Made a filing draft call in local environment (when testing, I commented out the authorization part to avoid the jwt staff check when running locally)
    • Draft
      Pasted image 20241004141806
    • Validate
      image
      By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@eason-pan-bc eason-pan-bc self-assigned this Oct 4, 2024
@eason-pan-bc eason-pan-bc marked this pull request as draft October 4, 2024 21:48
@eason-pan-bc eason-pan-bc marked this pull request as ready for review October 4, 2024 22:00
@eason-pan-bc eason-pan-bc marked this pull request as draft October 4, 2024 23:19
@eason-pan-bc eason-pan-bc marked this pull request as ready for review October 4, 2024 23:26
@eason-pan-bc eason-pan-bc force-pushed the 23349-validation-notice-of-withdrawal branch from 04e4431 to 620c916 Compare October 8, 2024 20:07
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Same as Aimee's work, we skip the scenarios of temporary businesses for now.

Copy link
Collaborator

@AimeeGao AimeeGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (^-^)

@eason-pan-bc eason-pan-bc merged commit 81df1ed into bcgov:main Oct 8, 2024
7 checks passed
chenhongjing added a commit that referenced this pull request Oct 22, 2024
* 23348 - Add allowable actions for notice of withdrawal (#3014)

* Add notice of withdrawal for existing business

* 23349 - validation notice of withdrawal (#3020)

* implement validation logic for NoW
* update schema version number in requirements
* exclude the new business scenario

* 23539 add batch_processing to colin_event_ids table (#3021)

* 23539 add batch_processing to colin_event_ids table

* add relationship, tests

* fix downgrade issue

* remove re-define batch_processing_step enum

* 23608 - Update furnishing entries transferred to bc mail+ (#3025)

* Fix bug

* 23697 - fix stage1 to stage2 dissolution transition bug (#3028)

* add SFTP off feature flag, modify stage 2 furnishing entry check, update tests
* adjust mail status check when FF is on
* add feature flag "disable-dissolution-sftp-bclaws"
* refactor stage 1 furnishing entries check
* update tests

* 23522-23562 continuation in workflow change (#3026)

* 23572 update dissolution letters (#3023)

* 23572 update dissolution letters

* add the dots

* 23845 - Bumped version numbers up for release 23.2a (#3030)

* bump version

* update entity-bn version

* udpate version

* 23563 - update review endpoint (#3029)

* 23563 - update review endpoint

* 23563 - update api spec

* 23563 - update api spec filing description

* Undo colin_event_id model changes (#3032)

---------

Co-authored-by: Aimee <Aimee.Gao@gov.bc.ca>
Co-authored-by: EasonPan <Eason.Pan@gov.bc.ca>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Vysakh Menon <vysakh.menon@gov.bc.ca>
Co-authored-by: ketaki-deodhar <116035339+ketaki-deodhar@users.noreply.github.com>
Co-authored-by: leodube-aot <122323255+leodube-aot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants