Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Restoration/Reinstatement Flow in response to Yui's comment #675

Conversation

JazzarKarim
Copy link
Collaborator

@JazzarKarim JazzarKarim commented Sep 7, 2023

Issue #: /bcgov/entity#16640

Description of changes:

  • Yui's comment: When firm registration numbers are entered, the UI returns a result but the "This business cannot be restored" message does not appear until the field loses focus. The error message should appear right after the business name is retrieved.
  • This PR also fixes this issue for alterations. It fixes the field focus and validation when we select a business that cannot be altered.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

@JazzarKarim JazzarKarim self-assigned this Sep 7, 2023
@JazzarKarim
Copy link
Collaborator Author

/gcbrun

@JazzarKarim
Copy link
Collaborator Author

screen-capture.4.webm

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-675-jao3khdh.web.app

@JazzarKarim JazzarKarim changed the title Updated in response to Yui's comment Updated Restoration/Reinstatement Flow in response to Yui's comment Sep 7, 2023
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the general solution, but I think you shouldn't use a form 😛

Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😺

@JazzarKarim JazzarKarim force-pushed the 16640-restoration-flow-fixes branch from 0e00327 to 1bbcfe6 Compare September 7, 2023 22:25
@JazzarKarim
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-675-jao3khdh.web.app

@JazzarKarim JazzarKarim merged commit d3912e6 into bcgov:feature-way-of-navigating Sep 7, 2023
JazzarKarim added a commit to JazzarKarim/namerequest that referenced this pull request Sep 8, 2023
…cgov#675)

* Updated in response to Yui's comment

* update package version after rebasing
JazzarKarim added a commit that referenced this pull request Sep 11, 2023
…675)

* Updated in response to Yui's comment

* update package version after rebasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants