Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18159 Fixed name input error message for non-xpro #729

Merged
merged 3 commits into from
Oct 16, 2023
Merged

18159 Fixed name input error message for non-xpro #729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92784ce
- app version = 5.2.10
severinbeauvais Oct 16, 2023
96de215
- BUG FIX: added missing corp type / entity type conversions
severinbeauvais Oct 16, 2023
dfa1260
- a bunch of fixed for GHA warnings
severinbeauvais Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.2.9",
"version": "5.2.10",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
11 changes: 7 additions & 4 deletions src/components/new-request/name-input.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,14 @@ export default class NameInput extends Vue {

get message (): string[] {
if (this.getErrors.includes('name')) {
if (this.isMrasSearch) {
return ['Please enter a corporation number to search for']
} else {
return ['Please enter the business\'s full legal name in home jurisdiction']
if (this.isXproFlow) {
if (this.isMrasJurisdiction && !this.getHasNoCorpNum) {
return ['Please enter a corporation number to search for']
} else {
return ['Please enter the business\'s full legal name in home jurisdiction']
}
}
return ['Please enter a name for the business']
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same logic as for the label (lines 87-96 above).

I always wondered why this logic was different. The answer is that it was wrong 😆


if (this.getErrors.includes('length')) {
Expand Down
Loading