18068 - Namerequest UI: Editing the Resubmit NR has the first name choice as empty. #740
Conversation
There was a problem hiding this comment.
Removing my approval -- I didn't looks closely enough at the code. The code change will always be True because it's not comparing the NR's type with an enum; it's looking at the truthiness of the enums directly, which is always True.
Rajandeep and I looked at this together and we're not sure why this code exists -- can't the designation from the original NR simply be copied in to the new NR? This code suggests that some NRs have a designation in the name but the designation field is empty. It would be good to have an example. We could then handle those specially.
The other option of exempting some types that we know don't have designations is less optimal but is probably safe and could be implemented as a last resort.
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-740-qail5x3t.web.app |
|
Do not merge this until after the release on Tuesday, October 31. |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-740-qail5x3t.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-740-qail5x3t.web.app |
*Issue #18068 bcgov/entity#18068
Description of changes:
Updated condition for applying designation for resubmission for SP/GP