Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18068 - Namerequest UI: Editing the Resubmit NR has the first name choice as empty. #740

Merged
merged 5 commits into from
Oct 31, 2023
+6 −5
Merged

18068 - Namerequest UI: Editing the Resubmit NR has the first name choice as empty. #740

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b91ec46
updated condition for SP/GP resubmission
Rajandeep98 Oct 26, 2023
766f8c8
Updated designation checking with designation type
Rajandeep98 Oct 27, 2023
d80f9d2
Simplified conditional and updated flag name
Rajandeep98 Oct 30, 2023
e5f45ac
version up
Rajandeep98 Oct 31, 2023
dfa3d74
Merge branch 'main' into 18068-Editing-Resubmit-NR
Rajandeep98 Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.3.2",
"version": "5.3.3",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
1 change: 1 addition & 0 deletions src/store/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,7 @@ function getNameDesignation (name: any): string {
if (name.designation) return name.designation
const words = name.name.split(' ')
const len = words.length
if (EntityTypes.FR || EntityTypes.GP || EntityTypes.DBA || EntityTypes.FI || EntityTypes.PA || EntityTypes.PAR) return ''
return words[len - 1]
}

Expand Down