19384 PNPM replacement #758
Conversation
…ot in supported change name FF
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app |
Dockerfile
Outdated
There was a problem hiding this comment.
This file can be removed.
Makefile
Outdated
There was a problem hiding this comment.
This file can be removed.
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app |
|
There are three tasks with errors. @pwei1018 @bolyachevets, is this acceptable? Any suggestions? |
the steps are failing, because it is still using the old workflow currently in namerequest repo (which calls Makefile etc.), the new workflow Patrick is working on is referenced here #758 |
|
!! Please hold on merge till sprint 21.2 released by April 30th noon !! |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app |
There was a problem hiding this comment.
need to add
"build-check": "node --max_old_space_size=8000 node_modules/@vue/cli-service/bin/vue-cli-service.js build", in the scripts section of package.json for the workflow to work
|
Thanks for this, book marking for auth-web |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app |
| ``` | ||
|
|
||
| ### Compiles and hot-reloads for development | ||
| ``` | ||
| npm run serve | ||
| pnpm run serve |
There was a problem hiding this comment.
You need to let people know about this change.
And also let them know they need to do npm i -g pnpm before they can build this project.
| version: 0.4.4 | ||
| sbc-common-components: | ||
| specifier: 3.0.8 | ||
| version: 3.0.8 |
There was a problem hiding this comment.
For some reason, this is out of date. (The package file specifies 3.0.12.)
Anyway, I updated this in PR #764.
Issue #: /bcgov/entity###
bcgov/entity#19384
Description of changes:
PNPM replacement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).