Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19384 PNPM replacement #758

Merged
merged 7 commits into from
Apr 24, 2024
Merged

19384 PNPM replacement #758

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c161283
disable Action button when change name to a numbered company and is n…
eve-git Apr 17, 2024
19e3304
Merge branch 'main' into 19384
eve-git Apr 19, 2024
c39c661
pnpm replacement
eve-git Apr 19, 2024
5ea967e
remove Dockerfile and Makefile
eve-git Apr 19, 2024
82e248f
update ci
eve-git Apr 24, 2024
cfa84d4
add build check
eve-git Apr 24, 2024
0b2ea05
resolving conflict
eve-git Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed.

Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM node:20.5.1 as build-stage
WORKDIR /app
COPY package*.json ./
RUN npm install
RUN pnpm install
COPY ./ .
RUN npm run build
RUN pnpm run build

FROM nginx:1.18.0 as production-stage

Expand Down
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed.

Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ DOCKER_NAME=namerequest
# expects the terminal to be openshift login
# expects export OPENSHIFT_REPOSITORY=""
#################################################################################
setup: ## Clean and Install npm dependencies
npm ci
setup:
pnpm install --frozen-lockfile

create-env: ## create the configration files from dev
@oc get configmap $(DOCKER_NAME)-dev-ui-configuration -n "$(OPENSHIFT_REPOSITORY)-dev" \
Expand All @@ -22,10 +22,10 @@ create-env: ## create the configration files from dev
ci: lint test

lint: ## Run linting ofcode.
npm run lint
pnpm run lint

test: ## Unit testing
npm run test:unit
pnpm run test:unit

#################################################################################
# COMMANDS - CD
Expand Down
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,32 @@

## Project setup
```
npm install
pnpm install
```

### Compiles and hot-reloads for development
```
npm run serve
pnpm run serve
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to let people know about this change.

And also let them know they need to do npm i -g pnpm before they can build this project.

```

### Compiles and minifies for production
```
npm run build
pnpm run build
```

### Run your tests
```
npm run test
pnpm run test
```

### Lints and fixes files
```
npm run lint
pnpm run lint
```

### Run your unit tests
```
npm run test:unit
pnpm run test:unit
```

### Customize configuration
Expand Down
Loading
Loading