Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18761, 18763 - EFT statement settings updates #2659

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Dec 8, 2023

Issue #:
bcgov/entity#18761
bcgov/entity#18763

Description of changes:

  • Fix issue where statement settings are always hidden when the feature flag for eft payment method is enabled. Statements settings are now always shown, but the statement frequency will be locked if the feature flag is enabled and payment method is EFT
  • Fix some styling issues as per UXPIN

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@ochiu
Copy link
Collaborator Author

ochiu commented Dec 8, 2023

Note, a small pay-api update is coming in another PR for this ticket is coming to automatically enable notifications and populate admin as recipient if there are no current recipients.

import { StatementListItem, StatementNotificationSettings, StatementRecipient, StatementSettings } from '@/models/statement'
import { mapActions, mapState } from 'pinia'
import CommonUtils from '@/util/common-util'
import LaunchDarklyService from 'sbc-common-components/src/services/launchdarkly.services'
Copy link
Collaborator

@seeker25 seeker25 Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move this component from class-api/options-api into composition-api
Similar to Statements.vue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, might be worth adding another point to the tickets (extra work done here)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped #18763 by 1pt

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@ochiu
Copy link
Collaborator Author

ochiu commented Dec 8, 2023

Example for EFT

Screenshot 2023-12-08 at 8 50 08 AM

Non EFT as an Admin (should be the same as previous)
Screenshot 2023-12-08 at 8 52 21 AM

@seeker25
Copy link
Collaborator

seeker25 commented Dec 8, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2659-nc5eu9he.web.app

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@ochiu
Copy link
Collaborator Author

ochiu commented Dec 8, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2659-nc5eu9he.web.app

@ochiu ochiu marked this pull request as ready for review December 8, 2023 23:28
@seeker25 seeker25 merged commit a63a31a into bcgov:main Dec 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants