-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18761, 18763 - EFT statement settings updates #2659
Conversation
Note, a small pay-api update is coming in another PR for this ticket is coming to automatically enable notifications and populate admin as recipient if there are no current recipients. |
import { StatementListItem, StatementNotificationSettings, StatementRecipient, StatementSettings } from '@/models/statement' | ||
import { mapActions, mapState } from 'pinia' | ||
import CommonUtils from '@/util/common-util' | ||
import LaunchDarklyService from 'sbc-common-components/src/services/launchdarkly.services' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move this component from class-api/options-api into composition-api
Similar to Statements.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a look thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, might be worth adding another point to the tickets (extra work done here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumped #18763 by 1pt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
/gcbrun |
Temporary Url for review: https://bcregistry-account-dev--pr-2659-nc5eu9he.web.app |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/gcbrun |
Temporary Url for review: https://bcregistry-account-dev--pr-2659-nc5eu9he.web.app |
Issue #:
bcgov/entity#18761
bcgov/entity#18763
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).