Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17224 - EFT Payment reminder notifications #1282

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Oct 17, 2023

Issue #:
bcgov/entity#17224

Description of changes:

  • added unpaid statement reminder job for 7 day reminder and payment due reminder
  • Included process to update invoices to overdue status

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1282 (e2758a9) into main (79924ce) will increase coverage by 0.46%.
Report is 27 commits behind head on main.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
+ Coverage   91.45%   91.92%   +0.46%     
==========================================
  Files         186      178       -8     
  Lines       11319    10562     -757     
==========================================
- Hits        10352     9709     -643     
+ Misses        967      853     -114     
Flag Coverage Δ
paymentjobs 83.57% <93.10%> (+3.35%) ⬆️
paymentreconciliationsqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/invoice.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/payment.py 95.87% <ø> (ø)
pay-api/src/pay_api/models/statement.py 97.61% <ø> (ø)
...api/src/pay_api/resources/v1/account_statements.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/eft_service.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/flags.py 80.35% <ø> (+2.39%) ⬆️
pay-api/src/pay_api/services/payment.py 97.02% <ø> (ø)
pay-api/src/pay_api/services/payment_service.py 97.94% <ø> (ø)
... and 6 more

... and 10 files with indirect coverage changes

@ochiu ochiu marked this pull request as ready for review October 17, 2023 15:43
@ochiu ochiu requested review from seeker25 and Jxio as code owners October 17, 2023 15:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochiu
Copy link
Collaborator Author

ochiu commented Oct 24, 2023

Latest updates from dicusssions:

  • updated requirements pay-api dependency to support latest changes and resolve job CI failing
  • Included process to update invoices to overdue status
  • renamed job as it doesn't just deal with notifications alone - also checks for overdue
  • removed custom query for checking total owing (now uses the pay-api model with updates to support per statement owing)
  • added / cleaned up tests

@ochiu ochiu requested a review from seeker25 October 24, 2023 15:17
@seeker25 seeker25 merged commit d4283fb into bcgov:main Oct 24, 2023
7 checks passed
AbrahamRostampoor pushed a commit to AbrahamRostampoor/sbc-pay that referenced this pull request Oct 26, 2023
* 17224 - EFT Payment reminder notifications

* PR Fixes

* PR Updates

* PR Updates / Refactor / Clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants