Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFT Reconciliation #1320

Merged
merged 2 commits into from
Nov 9, 2023
Merged

EFT Reconciliation #1320

merged 2 commits into from
Nov 9, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Nov 6, 2023

Issue #:
bcgov/entity#18468

Description of changes:

  • Add eft payment reconciliation for TDI17
  • Add eft credit record creation for TDI17 over payment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1320 (7162d6c) into main (79924ce) will increase coverage by 0.95%.
Report is 41 commits behind head on main.
The diff coverage is 94.03%.

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   91.45%   92.41%   +0.95%     
==========================================
  Files         186       18     -168     
  Lines       11319     1279   -10040     
==========================================
- Hits        10352     1182    -9170     
+ Misses        967       97     -870     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi ?
paymentjobs ?
paymentreconciliationsqueue 92.41% <94.03%> (+0.97%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ment-reconciliations/src/reconciliations/config.py 96.47% <100.00%> (+0.08%) ⬆️
...econciliations/src/reconciliations/eft/__init__.py 100.00% <100.00%> (ø)
...conciliations/src/reconciliations/eft/eft_enums.py 100.00% <100.00%> (ø)
...onciliations/src/reconciliations/eft/eft_errors.py 100.00% <100.00%> (ø)
...onciliations/src/reconciliations/eft/eft_header.py 100.00% <100.00%> (ø)
...iations/src/reconciliations/eft/eft_parse_error.py 100.00% <100.00%> (ø)
...nciliations/src/reconciliations/eft/eft_trailer.py 100.00% <100.00%> (ø)
...yment-reconciliations/src/reconciliations/enums.py 100.00% <100.00%> (ø)
...ment-reconciliations/src/reconciliations/worker.py 88.09% <100.00%> (+1.25%) ⬆️
...econciliations/src/reconciliations/eft/eft_base.py 98.36% <98.36%> (ø)
... and 3 more

... and 177 files with indirect coverage changes

@ochiu ochiu marked this pull request as ready for review November 7, 2023 03:41
Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level overview LGTM!

@ochiu ochiu removed the DoNotMerge label Nov 9, 2023
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochiu
Copy link
Collaborator Author

ochiu commented Nov 9, 2023

PR #1323 changes have allowed for this PR to share that code.

Updates have been done to make use of services in pay-api and test tweaks based on additional discussions.

@ochiu ochiu merged commit 6349210 into bcgov:main Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants