Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18439 - EFT Short name mapping endpoints support #1323

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Nov 9, 2023

Issue #:
bcgov/entity#18439

Description of changes:

  • Add eft short name resources to allow for mapping a short name to an auth account
  • Move service code for creating EFT payment, invoice reference, receipt records to EFT Service (Reconciliation job will be updated to use this code to reduce duplication)
  • logic to process invoices owing when a short name is mapped

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1323 (b81d3bb) into main (79924ce) will increase coverage by 0.49%.
Report is 40 commits behind head on main.
The diff coverage is 93.39%.

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   91.45%   91.95%   +0.49%     
==========================================
  Files         186      182       -4     
  Lines       11319    11758     +439     
==========================================
+ Hits        10352    10812     +460     
+ Misses        967      946      -21     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 82.00% <100.00%> (+0.18%) ⬆️
payadmin ∅ <ø> (?)
paymentjobs 82.97% <92.43%> (+2.75%) ⬆️
paymentreconciliationsqueue 92.71% <97.50%> (+1.26%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
...ent-jobs/tasks/direct_pay_automated_refund_task.py 85.71% <100.00%> (-0.34%) ⬇️
jobs/payment-jobs/tasks/distribution_task.py 97.75% <100.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
pay-api/src/pay_api/config.py 99.35% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_credit.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py 100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_process_status_code.py 100.00% <100.00%> (ø)
... and 44 more

... and 22 files with indirect coverage changes

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochiu ochiu merged commit 951df02 into bcgov:main Nov 9, 2023
23 checks passed
@ochiu ochiu mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants