Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10680 - Changes to allow account fees to be removed all at once. #1324

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Nov 10, 2023

Issue #:
bcgov/entity#10680

Description of changes:
Changes to allow account fees to be removed all at once.

bcgov/sbc-auth#2636 depends on this

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 requested review from Jxio and ochiu as code owners November 10, 2023 20:33
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #1324 (e4c7070) into main (79924ce) will increase coverage by 0.49%.
Report is 42 commits behind head on main.
The diff coverage is 93.07%.

@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
+ Coverage   91.45%   91.95%   +0.49%     
==========================================
  Files         186      183       -3     
  Lines       11319    12032     +713     
==========================================
+ Hits        10352    11064     +712     
- Misses        967      968       +1     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 82.00% <100.00%> (+0.18%) ⬆️
payadmin ∅ <ø> (?)
payapi 93.68% <92.38%> (-0.05%) ⬇️
paymentjobs 82.97% <92.43%> (+2.75%) ⬆️
paymentreconciliationsqueue 92.41% <94.03%> (+0.97%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
...ent-jobs/tasks/direct_pay_automated_refund_task.py 85.71% <100.00%> (-0.34%) ⬇️
jobs/payment-jobs/tasks/distribution_task.py 97.75% <100.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
pay-api/src/pay_api/config.py 99.35% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/base_model.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_credit.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py 100.00% <100.00%> (ø)
... and 49 more

... and 22 files with indirect coverage changes

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit 44c87e8 into bcgov:main Nov 10, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants