Upgrade to use latest DataBC version of SMK while retaining previous development branch changes #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a javascript error when printing directions. When a layer is not visible at the current zoom level, its value in an array of visible layers is undefined, causing an error when we retrieve layers in the print function. This change tests for the visible layer and, if missing, returns a simpler layer configuration. Co-authored-by: dgboss <darren.boss@gov.bc.ca>
After further discussion with Brendan of the GDX team, we agreed to reuse the same app ID in the tracker across hosted SMK apps. They distinguish sites by the URL of the apps the tracker sends requests from, so the app ID does not need to be unique per hosted SMK app.
This replaces ESRI legacy basemap API with new ESRI vector basemap API. Legacy basemaps are replaced with new ArcGIS basemaps except for Streets, which is replaced by the OpenStreetMaps Standard map instead of the ArcGIS Streets map. The "esri-leaflet-vector" library is added. Basemaps are now added to a separate map pane having a lower z-index than map layers in order to prevent basemaps from covering layers. An ESRI API key, stored as a Github secret, is added to site configuration and used in basemap requests.
tlink-221 styling update
Add minZoom and maxZoom properties when initializing the leaflet map
tlink-246 Update to Overhead Structures data
tlink-246 update filtering for overhead signs
tlink-246 add heights to overhead directional sign identify
This reverts the change from StamenTonerLight to Streets, originally requested in #220 and updated to restore StamenTonerLight.
Tlink 221
tlink-221 changed prov highway styling, adjusted layer order, and lin…
tlink-246 add heights to overhead-structure-without-height-marker
This reverts commit 03dead5.
This reverts commit 4b5c314.
This reverts commit ecd3610.
This reverts commit 2cce48e.
…reaks functionality
# Conflicts: # lib/smk.js # openshift/truck-route-planner-dev-bc.yaml
…to it's own file to allow the esriApiKey to be added the same way as the route planner api key
…t be injected, and the esri key file will not be generated
# Conflicts: # config/map.json # index.html
CEBergin-Vivid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to use latest DataBC version of SMK for issue:
#288
Set to use bcgov/smk version 1.2.1
Removed dialog-polyfill
Set Default basemap to Imagery
Merged in changes from previous develop branch (now develop_legacy) as there was functionality that may still be wanted