Make JSON library configurable #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you'd switch to Jason for v1.0 that would work for us too :) but I figured making it configurable and still defaulting to Poison would be easier for users. Worth noting that Phoenix will default to Jason in v2.0. |
|
Maybe also document that the dependency is now optional and how to change JSON library? ❤️ |
|
Updated, sorry for the wait. Btw, I stole documentation from https://github.com/elixir-ecto/postgrex#json-support :-) |
BleuShan
added a commit
to BleuShan/bamboo_sparkpost
that referenced
this pull request
Nov 18, 2018
* Remove hard dependency on poison following: beam-community/bamboo#374 * Cleanup deps
This was referenced Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: hexpm/hexpm#663