Skip to content

Commit

Permalink
Fixes readium#172 ARIA landmarks
Browse files Browse the repository at this point in the history
Added main landmark to epub content region.
Changed toolbar region landmark to banner from navigation
Added a region named Page Navigation to prev/next button area
Added Page Navigation to EN-US messages.json
Added empty alt attribute to empty library arrow image
  • Loading branch information
Becky Gibson committed Aug 25, 2014
1 parent 281e239 commit c322254
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion chrome-app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

<!-- This is all application-specific HTML -->
<body class="chrome-app">
<nav id="app-navbar" class="navbar" role="navigation">
<nav id="app-navbar" class="navbar" role="banner" aria-label="{{Strings.i18n_toolbar}}">
</nav>
<div id="app-container">
</div>
Expand Down
3 changes: 3 additions & 0 deletions i18n/_locales/en_US/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@
"i18n_page_next" : {
"message" : "Next Page"
},
"i18n_page_navigation" : {
"message" : "Page Navigation"
},
"chrome_accept_languages": {
"message": "$CHROME$ accepts $languages$ languages",
"placeholders": {
Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

<!-- This is all application-specific HTML -->
<body>
<nav id="app-navbar" class="navbar" role="navigation">
<nav id="app-navbar" class="navbar" role="banner">
</nav>
<div id="app-container">
</div>
Expand Down
2 changes: 1 addition & 1 deletion simpleviewer.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<!-- This is all application-specific HTML -->
<body>
<nav class="navbar" role="navigation">
<nav class="navbar" role="banner" aria-label="{{Strings.i18n_toolbar}}">
</nav>
<div id="app-container">
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/empty-library.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
<div id="empty-message">
{{strings.i18n_add_items}}
</div>
<img id="empty-message-arrow" src="images/library_arrow.png">
<img id="empty-message-arrow" src="images/library_arrow.png" alt="">
</div>
2 changes: 1 addition & 1 deletion templates/library-body.html
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<div class="row library-items">
<div class="row library-items" role="main">
</div>
7 changes: 3 additions & 4 deletions templates/reader-body.html
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
<div id="readium-toc-body"
aria-label="{{strings.toc}}"
role="navigation"
>
role="navigation">
</div>

<div id="reading-area">
<div id="reading-area" role="main">
<div id="epub-reader-container">
<div id="epub-reader-frame">
</div>
</div>

<div id="readium-page-btns">
<div id="readium-page-btns" role="region" tabindex="-1" aria-label="{{strings.i18n_page_navigation}}">
<!-- page left/right buttons inserted here when EPUB is loaded (page progression direction) -->
</div>

Expand Down

0 comments on commit c322254

Please sign in to comment.