Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add ARIA landmarks #172

Closed
becka11y opened this issue Aug 21, 2014 · 2 comments
Closed

Need to add ARIA landmarks #172

becka11y opened this issue Aug 21, 2014 · 2 comments

Comments

@becka11y
Copy link
Contributor

I just realized that there are not proper landmarks in the viewer. The toolbar is marked as a navigation landmark but there is no role=main. I think we also need a landmark on the next/prev button area.

I am working out the details of what the landmarks should be and will implement.

This is a V1 a11y issue.

@rkwright
Copy link
Member

To clarify, this is NOT the EPUB landmarks though it seems there is some overlap in intent. Is that correct?
http://www.w3.org/WAI/GL/wiki/Using_ARIA_landmarks_to_identify_regions_of_a_page
http://www.idpf.org/accessibility/guidelines/content/nav/landmarks.php

@becka11y
Copy link
Contributor Author

Correct, this is NOT about EPUB landmarks. These landmarks will allow the (screen reader) user to find the sections of the reader page - toolbar, epub content area, and page navigation area.

Although I do need to think about possible overlap with landmarks defined within the epub content. The ARIA spec states that where SHOULD (but not MUST) only be one instance of certain landmarks such as banner and main. If an EPUB includes landmarks they could overlap with what the cloud reader defines. However, the epub landmarks will be within the cloud reader's "main" section.

The Accessible EPUB 3 book does contain at least the complementary info landmark and it all works fine with the reader landmarks defined.

I'm just not sure if the page arrows should be marked as a landmark region or not and am asking around.

@rkwright rkwright added this to the v1 milestone Aug 22, 2014
becka11y pushed a commit to becka11y/readium-js-viewer that referenced this issue Aug 25, 2014
Added main landmark to epub content region.
Changed toolbar region landmark to banner from navigation
Added a region named Page Navigation to prev/next button area
Added Page Navigation to EN-US messages.json
Added empty alt attribute to empty library arrow image
becka11y pushed a commit to becka11y/readium-js-viewer that referenced this issue Aug 25, 2014
Added main landmark to epub content region.
Changed toolbar region landmark to banner from navigation
Added a region named Page Navigation to prev/next button area
Added Page Navigation to EN-US messages.json
Added empty alt attribute to empty library arrow image
becka11y pushed a commit to becka11y/readium-js-viewer that referenced this issue Aug 25, 2014
Added main landmark to epub content region.
Changed toolbar region landmark to banner from navigation
Added a region named Page Navigation to prev/next button area
Added Page Navigation to EN-US messages.json
Added empty alt attribute to empty library arrow image
ryanackley added a commit that referenced this issue Aug 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants