rework of command forms #411
Conversation
There was a problem hiding this comment.
Overall I really like the changes, I think they're much more maintainable. Also really like the more condensed layout. Great work! Pretty much all the comments are minor and/or can be pushed into a follow-on ticket. I'm really excited to see how much we can cut out once we get the job stuff onto this new form
--
Not sure where in the code it is, but I used the echo_list_model and when changing the drop-down for choices got the error below. Has to do with variables assigned to field values starting as explicitly undefined and then being defined upon user input.
MUI: A component is changing the default value state of an uncontrolled Select after being initialized. To suppress this warning opt to use a controlled Select.
--
Can't use keyboard navigation to change required v optional tabs. When adding to a list in the form, the Add button could use a little more context for screen readers (hidden element or an aria-label that gives context to what is being added)
| return ( | ||
| <TextField | ||
| {...field} | ||
| value={error ? value : (value!==null ? JSON.stringify(value) : '')} |
There was a problem hiding this comment.
You have a note there's a bug with errors and dictionary type - this line looks like it might be a good place to start debugging?
|
Layout and usability-wise I agree that we're moving in the right direction here. I'm okay merging this. If the comments made here need addressing then go ahead and do that and then merge. If we're going to address in a follow-up that's fine too. A couple of minor styling polish comments.
In the example above:
|
Closes #390 #389
Reworked command form to use react hook forms.
The form should have same functionality as previous form and fixes some issues with dynamic commands like with the evaluate command. Also
remake requestbutton now works with dynamic commandsThe job create path still uses the old command form.
Tracking of issues for follow on tickets: #410