Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch gh-pages branch using github token #105

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Fetch gh-pages branch using github token #105

merged 3 commits into from
Jan 27, 2022

Conversation

dmathieu
Copy link
Contributor

With #38 being open for over 1.5 year, I've taken the liberty to rebase the commit against the main branch, so it can be considered again.

This should:

@ktrz
Copy link
Member

ktrz commented Jan 27, 2022

Thank you very much for rebasing those changes @dmathieu. I just added one comment regarding the changelog. Could you also fix the linting errors? Probably running npm run format should fix the issue

CHANGELOG.md Outdated Show resolved Hide resolved
@dmathieu
Copy link
Contributor Author

Thank you. The lint should now be passing.

Copy link
Member

@ktrz ktrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ktrz ktrz merged commit 7e670e2 into benchmark-action:master Jan 27, 2022
@dmathieu dmathieu deleted the fetch-token branch January 27, 2022 10:46
haiiliin added a commit to haiiliin/github-action-benchmark that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error could not read Username for 'https://github.com': No such device or address Private repos fail
3 participants