Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch gh-pages branch using github token #38

Closed
wants to merge 1 commit into from

Conversation

leoholz
Copy link
Contributor

@leoholz leoholz commented Jun 25, 2020

This patch introduces the function git.fetch analogue to git.pull which uses the github token (if present) to authenticate the git fetch request. This enables using github-action-benchmark with private repositories (see #19).

@almartin82
Copy link

almartin82 commented Aug 8, 2020

@leoholz extremely useful PR!
I tried to use your fork on a private python repo as follows:

      - name: Store benchmark result
        uses: leoholz/github-action-benchmark@fix/private-repos

It fails as follows - any insight? not super confident that @fix/private-repos (vs @v1) is the proper way to reference your patch...

 Store benchmark result0s
    pythonLocation: /opt/hostedtoolcache/Python/3.7.8/x64
Run leoholz/github-action-benchmark@fix/private-repos
  with:
    name: Python Benchmark with pytest-benchmark
    tool: pytest
    output-file-path: benchmark_output.json
    fail-on-alert: true
    github-token: ***
    comment-on-alert: true
    gh-pages-branch: gh-pages
    benchmark-data-dir-path: dev/bench
    auto-push: false
    skip-fetch-gh-pages: false
    comment-always: false
    save-data-file: true
    alert-threshold: 200%
  env:
    PYTHON: 3.7
    pythonLocation: /opt/hostedtoolcache/Python/3.7.8/x64
##[error]File not found: '/home/runner/work/_actions/leoholz/github-action-benchmark/fix/private-repos/src/index.js'

Thanks!

@leoholz
Copy link
Contributor Author

leoholz commented Aug 8, 2020

Hi @almartin82 ! Please try uses: leoholz/github-action-benchmark@v1, this at least works in my setup.

@bitbacchus
Copy link

Works beautifully for me, thanks! Hope this will be pulled soon.

spl pushed a commit to terminusdb-labs/benchmark-tracker that referenced this pull request Aug 5, 2021
@aseure
Copy link

aseure commented Aug 24, 2021

Any update on this one?

@ktrz ktrz linked an issue Oct 28, 2021 that may be closed by this pull request
@ktrz
Copy link
Member

ktrz commented Oct 28, 2021

hi @leoholz
Thank you for your contribution. I took over the maintenance of this repo and I'm getting up to speed on all the issues and PRs.

Could you please update your PR to the latest master so that I can verify this again before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private repos fail
5 participants