New features added #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configurable pollInterval Added functions to calculate actual arrival time from waiting time and display it (or not) based on configuration (24h or 12h formats supported
Third option added to the if in getTimeDiv
novalore
commented
Feb 21, 2024
| @@ -22,10 +25,24 @@ Module.register("MMM-stib2", { | |||
| this.fetchColors() | |||
| .then(() => this.update()) | |||
| .then(() => { | |||
| // Schedule updates | |||
| // Convert pollInterval to a number if it's a string representation of a number | |||
There was a problem hiding this comment.
polInterval can be dangerous. To avoid issues I added validation here
novalore
commented
Feb 21, 2024
| slash.classList.add("fas", "fa-slash", "fa-stack-1x", "stib-time-icon"); | ||
|
|
||
| icon.appendChild(bus); | ||
| icon.appendChild(slash); | ||
| } else { |
There was a problem hiding this comment.
Forgot about this special case.
Restore this section if needed
Let's try code-GPT for this feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module works again with the new API and I am using it on my mirror, but noticed that waiting times are not always very easy to read and keep in mind, so I added options to visualize actual arrival times.
Added other options too and documented them in the README.
PollInterval is particularly useful when testing without Api key or checking the CSS on the MagicMirror page.
Merge if you like it