Skip to content

Commit

Permalink
Fix Electron 3 ABI
Browse files Browse the repository at this point in the history
Electron 3's ABI was incorrectly specified as 64 instead of 59, and now that Electron 4 has shipped and actually has ABI version 64, this is causing prebuild/prebuild-install to try to share binaries between Electron 3 and 4 which doesn't work.

Fixes electron#54
  • Loading branch information
Ben Demboski committed Jan 9, 2019
1 parent 7bc9664 commit c922a3f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ var supportedTargets = [
{runtime: 'electron', target: '1.7.0', abi: '54', lts: false},
{runtime: 'electron', target: '1.8.0', abi: '57', lts: false},
{runtime: 'electron', target: '2.0.0', abi: '57', lts: false},
{runtime: 'electron', target: '3.0.0', abi: '64', lts: false},
{runtime: 'electron', target: '3.0.0', abi: '59', lts: false},
{runtime: 'electron', target: '4.0.0', abi: '64', lts: false}
]

Expand Down

0 comments on commit c922a3f

Please sign in to comment.