Incorrect ABI version for Electron 3/4 #54
Comments
This was referenced Jan 9, 2019
Closed
bendemboski
pushed a commit
to bendemboski/node-abi
that referenced
this issue
Jan 9, 2019
Electron 3's ABI was incorrectly specified as 64 instead of 59, and now that Electron 4 has shipped and actually has ABI version 64, this is causing prebuild/prebuild-install to try to share binaries between Electron 3 and 4 which doesn't work. Fixes electron#54
Closed
|
Electron 4.0.4 now has a dedicated ABI number of 69. Refs: #57 |
ralphtheninja
added a commit
to deltachat/deltachat-node
that referenced
this issue
Feb 6, 2019
See electron/node-abi#54 and electron/node-abi@9e4c1a6 for fixes to incorrect abi version for electron 4.0.0 (it was using electron 3.0.0 headers)
ralphtheninja
added a commit
to deltachat/deltachat-node
that referenced
this issue
Feb 13, 2019
See electron/node-abi#54 and electron/node-abi@9e4c1a6 for fixes to incorrect abi version for electron 4.0.0 (it was using electron 3.0.0 headers)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm pretty sure the wrong ABI was specified for Electron 3, and now that Electron 4 has rolled out, its ABI incorrectly matches Electron 3's, which is causing some issues with prebuilding.
Electron 3.0.0 uses
electron/nodev9.7.0-33-g538a5023af, which corresponds to Node 9.7.0, which has ABI version 59. But Electron 3 was, I believe erroneously, specified as ABI version 64.Electron 4.0.0 uses
electron/node4d44266b78256449dd6ae86e419e3ec07257b569, which corresponds to Node 10.11.0, which has ABI version 64.So now Electron 4.0.0 is correctly specified to have ABI version 64, but 3.0.0 incorrectly shows the same ABI version as 4.0.0, which is screwing up
prebuildprojects, because it thinks it can reuse Electron 3 binaries for Electron 4 (causing this, and maybe this).The text was updated successfully, but these errors were encountered: