fix: parenthesizes around arrow function body returning object #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect when using babel parser
|
I'm the one who broke this, and I actually my own PR open now which would resolve your issue and others: #1068 |
|
The issue appears to have been fixed now by #1068, so I believe this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #743, fixes #744
I caught the same issue when having codemod changing function type annotations
it looks to be caused by
69e1227#diff-f2dc028279be53ae3c8d23750deff945df0bf5cafd17fe66d0a10d0b7421e93fR344-R345
which for me looks a bit suspicious, and when reverting - does not look to break any existing tests
adopted the test from #744