Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parenthesizes around arrow function body returning object #830

Closed
wants to merge 3 commits into from
Closed

fix: parenthesizes around arrow function body returning object #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d0e9a6
revert suspicious change
zxbodya Dec 16, 2020
cc61f1b
test to ensure parenthesizes around arrow function body returning obj…
coderaiser Aug 30, 2020
2e0072d
update the test
zxbodya Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/fast-path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,7 @@ FPp.needsParens = function (assumeExpressionContext) {
return false;
}

if (
parent.type === "ParenthesizedExpression" ||
(node.extra && node.extra.parenthesized)
) {
if (parent.type === "ParenthesizedExpression") {
return false;
}

Expand Down
27 changes: 27 additions & 0 deletions test/printer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,33 @@ describe("printer", function () {
assert.strictEqual(pretty, code);
});

it("adds parenthesis around arrow functions body when returning object expression using babel parser", function () {
const expected = [
"() => ({",
" a: 'b'",
"});",
].join(eol);
const source = [
"(a) => ({",
" a: 'b'",
"});"
].join(eol);
const ast = recast.parse(source, {
parser: require('@babel/parser'),
});
const traverse = require('@babel/traverse').default;

traverse(ast, {
Function(path: any) {
path.get('params.0').remove();
}
});

const printer = new Printer();
const result = printer.print(ast).code;
assert.strictEqual(result, expected);
});

it("prints class property initializers with type annotations correctly", function () {
const code = ["class A {", " foo = (a: b): void => {};", "}"].join(eol);

Expand Down