Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loops in resolving cookbooks in the uploader #1781

Merged
merged 4 commits into from
Jun 8, 2018

Conversation

lamont-granquist
Copy link
Contributor

see code comment for gory details.

closes #1780

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Copy link
Contributor

@thommay thommay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@lamont-granquist
Copy link
Contributor Author

hmmm, there may be a legit busted spec...

this makes my head hurt a bit less than the bonkers code that
was here...

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist lamont-granquist merged commit c8a90c4 into master Jun 8, 2018
@lamont-granquist lamont-granquist deleted the lcg/fix-inifite-loops branch June 8, 2018 22:06
@shayangz
Copy link

Any chance this will be pushed up to chefdk soon?

Alternatively, what is the best way to grab this version if one has chefdk 3.0.36 which bundles the broken berks 7.0.2 version?

@lock
Copy link

lock bot commented Aug 9, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

berks upload doesn't handle circular dependencies (v7.0.2)
4 participants