[SHACK-295] Kitchen generator conflicts on 'chefignore' #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Kitchen generator runs it tries to create a 'chefignore' file that is different from what Berkshelf creates. Because Berkshelf invokes the kitchen generator by default (if the libraries are present) this causes the 'chef verify berkshelf --unit' command to fail. It ends up hanging indefinitely because the 'chefignore' that TK and Berkshelf create are different, so it prompts the user to resolve this conflict. This stdin prompt in the automated pipeline causes the tests to hang forever until they are killed. This is a partial revert of #1702 Signed-off-by: tyler-ball <tball@chef.io>
cheeseplus
approved these changes
Aug 7, 2018
|
CHEFSTYLE is still failing for the |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Kitchen generator runs it tries to create a 'chefignore' file
that is different from what Berkshelf creates. Berkshelf tests ran from the ChefDK via
chef verify berkshelf --unitend up hanging indefinitely because the 'chefignore' that TK and Berkshelf create are different, so it prompts the user to resolve thisconflict. This stdin prompt in the automated pipeline causes the tests
to hang forever until they are killed.
Because Berkshelf invokes
the kitchen generator by default (if the libraries are present) this
causes the 'chef verify berkshelf --unit' command to fail.
This is a partial revert of #1702
Signed-off-by: tyler-ball tball@chef.io