build: update webpack for npm linking plugins (apache#11253)

betodealmeida · Oct 13, 2020 · eb389ba · eb389ba
1 parent 16f7b2b
commit eb389ba
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/superset-frontend/tsconfig.json b/superset-frontend/tsconfig.json
@@ -30,5 +30,6 @@
     "./node_modules/*superset-ui*/**/types/**/*",
     // and the type defs of their dependencies
     "./node_modules/*superset-ui*/**/node_modules/**/*.d.ts"
-  ]
+  ],
+  "exclude": ["./node_modules/*superset-ui*/**/node_modules/@superset-ui/**/*"]
 }
diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
@@ -265,12 +265,19 @@ const config = {
     },
   },
   resolve: {
+    modules: [APP_DIR, 'node_modules'],
     alias: {
-      src: path.resolve(APP_DIR, './src'),
       'react-dom': '@hot-loader/react-dom',
-      stylesheets: path.resolve(APP_DIR, './stylesheets'),
-      images: path.resolve(APP_DIR, './images'),
-      spec: path.resolve(APP_DIR, './spec'),
+      // force using absolute import path of the @superset-ui/core and @superset-ui/chart-controls
+      // so that we can `npm link` viz plugins without linking these two base packages
+      '@superset-ui/core': path.resolve(
+        APP_DIR,
+        './node_modules/@superset-ui/core',
+      ),
+      '@superset-ui/chart-controls': path.resolve(
+        APP_DIR,
+        './node_modules/@superset-ui/chart-controls',
+      ),
     },
     extensions: ['.ts', '.tsx', '.js', '.jsx'],
     symlinks: false,