Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireframeConfig change affects only currently spawned meshes #11782

Closed
Shatur opened this issue Feb 8, 2024 · 0 comments · Fixed by #11792
Closed

WireframeConfig change affects only currently spawned meshes #11782

Shatur opened this issue Feb 8, 2024 · 0 comments · Fixed by #11792
Labels
A-Gizmos Visual editor and debug gizmos A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Comments

@Shatur
Copy link
Contributor

Shatur commented Feb 8, 2024

Bevy version

0.12.1

What you did

Set global in WireframeConfig to true.

What went wrong

It affected only current meshes. All newly spawned meshes won't have a rendered wireframe.

I would expect the global configuration to affect all meshes.
@Shatur Shatur added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 8, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-Gizmos Visual editor and debug gizmos and removed S-Needs-Triage This issue needs to be labelled labels Feb 8, 2024
@Kanabenki Kanabenki mentioned this issue Feb 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
@Kanabenki
Fix global wireframe behavior not being applied on new meshes (#11792)
2d90b20 
# Objective

- Fixes #11782.

## Solution

- Remove the run condition for `apply_global_wireframe_material`, since
it prevent detecting when meshes are added or the `NoWireframe` marker
component is removed from an entity. Alternatively this could be done by
using a run condition like "added `Handle<Mesh>` or removed
`NoWireframe` or `WireframeConfig` changed" but this seems less clear to
me than directly letting the queries on
`apply_global_wireframe_material` do the filtering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix global wireframe behavior not being applied on new meshes Kanabenki/bevy
2 participants
@alice-i-cecile @Shatur