Fix global wireframe behavior not being applied on new meshes #11792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
WireframeConfig
change affects only currently spawned meshes #11782.Solution
apply_global_wireframe_material
, since it prevent detecting when meshes are added or theNoWireframe
marker component is removed from an entity. Alternatively this could be done by using a run condition like "addedHandle<Mesh>
or removedNoWireframe
orWireframeConfig
changed" but this seems less clear to me than directly letting the queries onapply_global_wireframe_material
do the filtering.