Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove for_each and for_each_mut APIs #4059

Closed
alice-i-cecile opened this issue Feb 28, 2022 · 0 comments · Fixed by #11974
Closed

Remove for_each and for_each_mut APIs #4059

alice-i-cecile opened this issue Feb 28, 2022 · 0 comments · Fixed by #11974
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

As discussed in #3765, these APIs no longer appear to be measurably faster than query.iter() mechanisms after #2254.

Having two ways to do the same thing is not ideal, and this API is generally less flexible and considered harder to read.

What solution would you like?

Remove these APIs.

Additional context

Some ballpark benchmarks were done in #3765, but this change should be accompanied by higher quality testing.
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times C-Code-Quality A section of code that is hard to understand or change labels Feb 28, 2022
@alice-i-cecile alice-i-cecile changed the title Remove for_each and for_each_mut APIs Remove for_each and for_each_mut APIs Feb 28, 2022
@james7132 james7132 mentioned this issue Feb 28, 2022
Closed
@james7132 james7132 mentioned this issue Feb 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2024
@james7132
Remove APIs deprecated in 0.13 (#11974)
bc82749 
# Objective
We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It
should be OK to remove them in 0.14's release. Fixes #4059. Fixes #9011.

## Solution
Remove them.
msvbg pushed a commit to msvbg/bevy that referenced this issue Feb 26, 2024
@james7132 @msvbg
Remove APIs deprecated in 0.13 (bevyengine#11974)
5393ca4 
# Objective
We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It
should be OK to remove them in 0.14's release. Fixes bevyengine#4059. Fixes bevyengine#9011.

## Solution
Remove them.
msvbg pushed a commit to msvbg/bevy that referenced this issue Feb 26, 2024
@james7132 @msvbg
Remove APIs deprecated in 0.13 (bevyengine#11974)
b3dc309 
# Objective
We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It
should be OK to remove them in 0.14's release. Fixes bevyengine#4059. Fixes bevyengine#9011.

## Solution
Remove them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove APIs deprecated in 0.13 james7132/bevy
Yeet for_each james7132/bevy
1 participant
@alice-i-cecile