Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove APIs deprecated in 0.13 #11974

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Remove APIs deprecated in 0.13 #11974

merged 9 commits into from
Feb 19, 2024

Conversation

james7132
Copy link
Member

@james7132 james7132 commented Feb 19, 2024 •
edited
Loading

Objective

We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It should be OK to remove them in 0.14's release. Fixes #4059. Fixes #9011.

Solution

Remove them.

@james7132 james7132 added A-Rendering Drawing game state to the screen A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Feb 19, 2024
@james7132 james7132 added this to the 0.14 milestone Feb 19, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 19, 2024
@james7132
Copy link
Member Author

@alice-i-cecile mind taking a look at the updates to the Query doc? I needed to rewrite some of it to accomodate the removal of Query::for_each.

alice-i-cecile
alice-i-cecile approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look solid, thanks for the ping :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 19, 2024
Merged via the queue into bevyengine:main with commit bc82749 Feb 19, 2024
23 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@james7132 @msvbg
Remove APIs deprecated in 0.13 (bevyengine#11974)
5393ca4 
# Objective
We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It
should be OK to remove them in 0.14's release. Fixes bevyengine#4059. Fixes bevyengine#9011.

## Solution
Remove them.
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@james7132 @msvbg
Remove APIs deprecated in 0.13 (bevyengine#11974)
b3dc309 
# Objective
We deprecated quite a few APIs in 0.13. 0.13 has shipped already. It
should be OK to remove them in 0.14's release. Fixes bevyengine#4059. Fixes bevyengine#9011.

## Solution
Remove them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@afonsolage afonsolage afonsolage approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
4 participants
@james7132 @afonsolage @alice-i-cecile @mockersf