Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cpal to 0.14.0 #5774

Closed
TimJentzsch opened this issue Aug 23, 2022 · 3 comments
Closed

Upgrade cpal to 0.14.0 #5774

TimJentzsch opened this issue Aug 23, 2022 · 3 comments
Labels
A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes

Comments

@TimJentzsch
Copy link
Contributor

What problem does this solve or what need does it fill?

The previous version of cpal depended on two versions of parking_lot, increasing compile times and sizes. With release 0.14.0, this has been fixed.

What solution would you like?

We should upgrade to the latest cpal version and update the skipped crates in deny.toml. We should at least be able to remove the parking_lot lines:

bevy/deny.toml

Lines 36 to 48 in 5e2d9b4

skip = [
{ name = "cfg-if", version = "0.1" }, # from winit v0.26.0
{ name = "core-foundation", version = "0.7" }, # from winit v0.26.0
{ name = "core-foundation-sys", version = "0.7" }, # from winit v0.26.0
{ name = "core-graphics", version = "0.19" }, # from winit v0.26.0
{ name = "ndk", version = "0.5" }, # from winit v0.26.1
{ name = "ndk-glue", version = "0.5" }, # from winit v0.26.1
{ name = "ndk-sys", version = "0.2" }, # from winit v0.26.1
{ name = "parking_lot", version = "0.11" }, # from rodio v0.15.0
{ name = "parking_lot_core", version = "0.8" }, # from rodio v0.15.0
{ name = "stdweb", version = "0.1" }, # from rodio v0.15.0
{ name = "nix", version = "0.23.1" }, # from alsa v0.6.0
]

Additional context
@TimJentzsch TimJentzsch added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 23, 2022
@mockersf
Copy link
Member

Bevy doesn't depend on cpal directly, but does through rodio: https://github.com/RustAudio/rodio/blob/55d957f8b40c59fccea4162c4b03f6dd87a7a4d9/Cargo.toml#L14

Hopefully rodio will release soon, I've been waiting for an update for a long time...

@TimJentzsch
Copy link
Contributor Author

Good point, I created an issue for rodio as well: RustAudio/rodio#433

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled D-Trivial Nice and easy! A great choice to get started with Bevy labels Aug 23, 2022
@harudagondi
Copy link
Member

now we just have to wait for a new rodio release

@TimJentzsch TimJentzsch mentioned this issue Sep 19, 2022
Closed
@bors bors bot closed this as completed in 047b437 Sep 19, 2022
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 19, 2022
@mockersf @james7132
Update rodio requirement from 0.15 to 0.16 (bevyengine#6020)
bf5d2d1 
# Objective

- bevyengine#6019 but with the duplicate package list updated
- Fixes bevyengine#5774
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@mockersf @james7132
Update rodio requirement from 0.15 to 0.16 (bevyengine#6020)
83157c6 
# Objective

- bevyengine#6019 but with the duplicate package list updated
- Fixes bevyengine#5774
@harudagondi harudagondi moved this to Done in Audio Nov 17, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@mockersf @ItsDoot
Update rodio requirement from 0.15 to 0.16 (bevyengine#6020)
1008e55 
# Objective

- bevyengine#6019 but with the duplicate package list updated
- Fixes bevyengine#5774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes
Projects
Audio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Update rodio requirement from 0.15 to 0.16 mockersf/bevy
4 participants
@alice-i-cecile @mockersf @TimJentzsch @harudagondi