Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot access WgpuAdapterInfo anymore? #6598

Closed
djeedai opened this issue Nov 13, 2022 · 3 comments
Closed

Cannot access WgpuAdapterInfo anymore? #6598

djeedai opened this issue Nov 13, 2022 · 3 comments
Labels
A-ECS Entities, components, systems, and events A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!

Comments

@djeedai
Copy link
Contributor

djeedai commented Nov 13, 2022

Bevy version

0.9

What you did

Upgrading from v0.8.

The documentation of WgpuSettings still claims to use "the WgpuAdapterInfo resource", but WgpuAdapterInfo is not a resource since it's an alias for a WGPU type and it probably lost the default Resource implementation.

What went wrong

Doesn't build.

// the trait bound `WgpuAdapterInfo: bevy::prelude::Resource` is not satisfied
let adapter_name = app
    .world
    .get_resource::<WgpuAdapterInfo>()
    .map(|ai| &ai.name[..])
    .unwrap();
@djeedai djeedai added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-ECS Entities, components, systems, and events P-Regression Functionality that used to work but no longer does. Add a test for this! labels Nov 13, 2022
@djeedai
Copy link
Contributor Author

djeedai commented Nov 13, 2022

Note: WgpuAdapterInfo doesn't appear in the migration guide https://bevyengine.org/learn/book/migration-guides/0.8-0.9/

@tim-blackbird
Copy link
Contributor

The AdapterInfo is now wrapped in the RenderAdapterInfo Resource.

@djeedai
Copy link
Contributor Author

djeedai commented Nov 13, 2022

Confirmed working with RenderAdapterInfo. Do we / can we upgrade the migration guide for it maybe?

@jinleili jinleili mentioned this issue Dec 26, 2022
Closed
@bors bors bot closed this as completed in 741a91e Dec 26, 2022
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@jinleili @alradish
Replace WgpuAdapterInfo with RenderAdapterInfo in the documentati…
f8419a4 
…on. (bevyengine#7036)

# Objective

Fixes bevyengine#6598
In addition, macOS can also support GL backends through ANGLE.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@jinleili @ItsDoot
Replace WgpuAdapterInfo with RenderAdapterInfo in the documentati…
1c7f256 
…on. (bevyengine#7036)

# Objective

Fixes bevyengine#6598
In addition, macOS can also support GL backends through ANGLE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
No milestone
2 participants
@djeedai @tim-blackbird