-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Events::extend with Vec::extend #2149
Commits on May 11, 2021
-
Moves impl blocks directly after types, organizes like-types together, presents shared functionality first
Configuration menu - View commit details
-
Copy full SHA for 7c224f0 - Browse repository at this point
Copy the full SHA 7c224f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8be5e90 - Browse repository at this point
Copy the full SHA 8be5e90View commit details -
Renamed State to BufferState for clarity
Event buffer's state should not clash with State concept
Configuration menu - View commit details
-
Copy full SHA for 0140b63 - Browse repository at this point
Copy the full SHA 0140b63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ae131f - Browse repository at this point
Copy the full SHA 9ae131fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 620bbbc - Browse repository at this point
Copy the full SHA 620bbbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42dad93 - Browse repository at this point
Copy the full SHA 42dad93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 766e25c - Browse repository at this point
Copy the full SHA 766e25cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ca992e - Browse repository at this point
Copy the full SHA 0ca992eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb18f07 - Browse repository at this point
Copy the full SHA bb18f07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51b6195 - Browse repository at this point
Copy the full SHA 51b6195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1da3c34 - Browse repository at this point
Copy the full SHA 1da3c34View commit details -
Move event.rs example to FixedTimeStep
Consistency with event_consumer and improves simplicity
Configuration menu - View commit details
-
Copy full SHA for e1142ad - Browse repository at this point
Copy the full SHA e1142adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d5185e - Browse repository at this point
Copy the full SHA 0d5185eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7a90b1 - Browse repository at this point
Copy the full SHA c7a90b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 987a62f - Browse repository at this point
Copy the full SHA 987a62fView commit details
Commits on May 12, 2021
-
Add test that catches EventReader + drain failure observed in example
Fails on line 467, after we try again
Configuration menu - View commit details
-
Copy full SHA for e0b64fd - Browse repository at this point
Copy the full SHA e0b64fdView commit details -
Reset events metadata when drained
Required to ensure Event readers continue functioning correctly
Configuration menu - View commit details
-
Copy full SHA for 591bfdd - Browse repository at this point
Copy the full SHA 591bfddView commit details -
Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for defe65b - Browse repository at this point
Copy the full SHA defe65bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d0809f - Browse repository at this point
Copy the full SHA 3d0809fView commit details -
Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 06d26e5 - Browse repository at this point
Copy the full SHA 06d26e5View commit details -
Implement Events::extend with Vec::extend
Problem: - Events::extend manually called Vec::push for each element of the provided iterator. - This can potentially be an expensive. Solution: - Use Vec::extend over a Vec::push for loop.
Configuration menu - View commit details
-
Copy full SHA for 2638ec5 - Browse repository at this point
Copy the full SHA 2638ec5View commit details