Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Support topologies other than TriangleList #3349

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Support topologies other than TriangleList #3349

wants to merge 1 commit into from

Conversation

HackerFoo
Copy link
Contributor

Objective

Fixes #3346

Solution

I've encoded the topology in the MeshKey similar to how MSAA samples are handled.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 16, 2021
@HackerFoo HackerFoo closed this Dec 16, 2021
@HackerFoo HackerFoo reopened this Dec 16, 2021
@cart cart added this to the Bevy 0.6 milestone Dec 16, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible P-Regression Functionality that used to work but no longer does. Add a test for this! and removed S-Needs-Triage This issue needs to be labelled labels Dec 17, 2021
@cart
Copy link
Member

cart commented Dec 18, 2021

Makes sense to me!

@cart
Copy link
Member

cart commented Dec 18, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 18, 2021
@HackerFoo
Support topologies other than TriangleList (#3349)
73f524f 
# Objective

Fixes #3346

## Solution

I've encoded the topology in the `MeshKey` similar to how MSAA samples are handled.
@bors
Copy link
Contributor

bors bot commented Dec 18, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support topologies other than TriangleList [Merged by Bors] - Support topologies other than TriangleList Dec 18, 2021
@bors bors bot closed this Dec 18, 2021
@Davier Davier mentioned this pull request Dec 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging this pull request may close these issues.

Mesh topologies other than TriangleLists are not supported in the new renderer
3 participants
@HackerFoo @cart @alice-i-cecile